mimaison commented on code in PR #18460:
URL: https://github.com/apache/kafka/pull/18460#discussion_r1958428791
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1293,16 +1292,16 @@ class UnifiedLog(@volatile var logStartOffset: Long,
} else {
// We need to search the first segment whose largest timestamp is >=
the target timestamp if there is one.
if (remoteLogEnabled() && !isEmpty) {
- if (remoteLogManager.isEmpty) {
+ if (remoteOffsetReader.isEmpty) {
Review Comment:
I wonder if keeping "RemoteLogManager" is clearer as it's a term already
visible, and known, by users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
