lucasbru opened a new pull request, #18979:
URL: https://github.com/apache/kafka/pull/18979

   This change implements the basic RPC handling StreamsGroupHeartbeat and 
StreamsGroupDescribe. This includes:
    - Adding an option to enable streams groups on the broker
    - Passing describe and heartbeats to the right shard of the group 
coordinator
    - The handler inside the GroupMetadatManager for StreamsGroupDescribe is 
fairly trivial, and is included directly in this PR.
    - The handler for StreamsGroupHeartbeat is complex and not included in this 
PR yet. Instead, a UnsupportedOperationException is thrown. However, the 
interface is already defined: The result of a streamsGroupHeartbeat is a 
response, together with a list of internal topics to be created.
    - Inside `KafkaApis`, the handler for streamsGroupHeartbeat uses this 
result to attempt to create all missing internal topics using 
AutoTopicCreationManager. CREATE TOPIC ACLs are checked. The unit tests class 
AutoTopicCreationManager is brought back (it was recently deleted during a ZK 
removal PR).
   
   The heartbeat implementation inside the `GroupMetadataManager`, which 
actually implements the assignment / reconciliation logic, will come in a 
follow-up PR.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to