smjn commented on code in PR #18848:
URL: https://github.com/apache/kafka/pull/18848#discussion_r1963643829
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -6855,6 +6861,45 @@ public void createGroupTombstoneRecords(
group.createGroupTombstoneRecords(records);
}
+ /**
+ * Returns an optional of delete share group request object to be used
with the persister.
+ * Empty if no subscribed topics or if the share group is empty.
+ * @param shareGroup - A share group
+ * @return Optional of object representing the share group state delete
request.
+ */
+ public Optional<DeleteShareGroupStateParameters>
shareGroupBuildPartitionDeleteRequest(ShareGroup shareGroup) {
+ TopicsImage topicsImage = metadataImage.topics();
+ Set<String> subscribedTopics =
shareGroup.subscribedTopicNames().keySet();
Review Comment:
Yes correct, we will be replacing the `shareGroup.subscribedTopicNames` call
with fetching data from a new timeline hashmap which would be populated using
the initialize state RPC -
[KAFKA-18827](https://issues.apache.org/jira/browse/KAFKA-18827).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
