lucasbru commented on code in PR #18911:
URL: https://github.com/apache/kafka/pull/18911#discussion_r1963795902
##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommand.java:
##########
@@ -270,7 +285,7 @@ private void printOffsets(StreamsGroupDescription
description, boolean verbose)
String fmt = "%" + (-groupLen) + "s %" + (-maxTopicLen) +
"s %-10s %-15s %s\n";
System.out.printf(fmt, "GROUP", "TOPIC", "PARTITION",
"LEADER-EPOCH", "OFFSET-LAG");
for (Map.Entry<TopicPartition, Long> offset :
offsets.entrySet()) {
- System.out.printf(fmt, description.groupId(),
offset.getKey().topic(), offset.getKey().partition(), "", offset.getValue());
+ System.out.printf(fmt, description.groupId(),
offset.getKey().topic(), offset.getKey().partition(), description.groupEpoch(),
offset.getValue());
Review Comment:
Ah - I see the comment now. I think in the consumer group tool, we have
leader-epoch with verbose, and no leader-epoch without verbose. Shouldn't we
just use the same behavior to ease people moving between the tools?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
