[
https://issues.apache.org/jira/browse/KAFKA-7461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731071#comment-16731071
]
ASF GitHub Bot commented on KAFKA-7461:
---------------------------------------
AndrewJSchofield commented on pull request #6077: KAFKA-7461: Add tests for
logical types
URL: https://github.com/apache/kafka/pull/6077
Added testing of logical types for Kafka Connect in support of KIP-145
features.
Added tests for Boolean, Time, Date and Timestamp, including the valid
conversions.
The area of ISO8601 strings is a bit of a mess because the tokenizer is not
compatible with
that format, and a subsequent JIRA will be needed to fix that.
A few small fixes as well as creating test cases, but they're clearly just
corrections such as
using 0 to mean January (java.util.Calendar uses zero-based month numbers).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Connect Values converter should have coverage of logical types
> --------------------------------------------------------------
>
> Key: KAFKA-7461
> URL: https://issues.apache.org/jira/browse/KAFKA-7461
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
> Affects Versions: 1.1.1, 2.0.0
> Reporter: Ewen Cheslack-Postava
> Assignee: Andrew Schofield
> Priority: Blocker
> Labels: newbie, test
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> Per fix from KAFKA-7460, we've got some gaps in testing for the Values
> converter added in KIP-145, in particular for logical types. It looks like
> there are a few other gaps (e.g. from quick scan of coverage, maybe the float
> types as well), but logical types seem to be the bulk other than trivial
> wrapper methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
