smjn commented on code in PR #18968:
URL: https://github.com/apache/kafka/pull/18968#discussion_r1965706156
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##########
@@ -317,16 +319,12 @@ public
CoordinatorResult<WriteShareGroupStateResponseData, CoordinatorRecord> wr
CoordinatorRecord record = generateShareStateRecord(partitionData,
key);
// build successful response if record is correctly created
- WriteShareGroupStateResponseData responseData = new
WriteShareGroupStateResponseData()
- .setResults(
- Collections.singletonList(
-
WriteShareGroupStateResponse.toResponseWriteStateResult(key.topicId(),
- Collections.singletonList(
-
WriteShareGroupStateResponse.toResponsePartitionResult(
- key.partition()
- ))
- ))
- );
+ WriteShareGroupStateResponseData responseData = new
WriteShareGroupStateResponseData().setResults(
Review Comment:
Will need to refactor all the code - this is the acceptable style since
previous one causes alignment issues.
I have a JIRA for the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
