[
https://issues.apache.org/jira/browse/KAFKA-6627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732592#comment-16732592
]
ASF GitHub Bot commented on KAFKA-6627:
---------------------------------------
likan999 commented on pull request #6084: KAFKA-6627: Prevent config default
values overriding ones specified through --producer-property on command line.
URL: https://github.com/apache/kafka/pull/6084
In Console{Producer,Consumer}, extraProducerProps (options specified in
--producer-property) is applied first, then overriden unconditionally,
even if the value is not specified explicitly (and default value is
used). This patch fixes it so that it doesn't override the existing
value set by --producer-property if it is not explicitly specified.
The contribution is my original work and I license the work to the
project under the project's open source license.
Signed-off-by: Kan Li <li...@uber.com>
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
Testing strategy: print out acks value in KafkaProducer.configureAcks, and
start producer using --producer-property aks=all, and then observe the
difference with and without the patch.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Console producer default config values override explicitly provided properties
> ------------------------------------------------------------------------------
>
> Key: KAFKA-6627
> URL: https://issues.apache.org/jira/browse/KAFKA-6627
> Project: Kafka
> Issue Type: Bug
> Components: tools
> Reporter: Jason Gustafson
> Assignee: Kan Li
> Priority: Minor
> Labels: newbie
>
> Some producer properties can be provided through custom parameters (e.g.
> {{\-\-request-required-acks}}) and explicitly through
> {{\-\-producer-property}}. At the moment, some of the custom parameters have
> default values which actually override explicitly provided properties. For
> example, if you set {{\-\-producer-property acks=all}} when starting the
> console producer, the argument will be ignored since
> {{\-\-request-required-acks}} has a default value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
