m1a2st commented on code in PR #18998:
URL: https://github.com/apache/kafka/pull/18998#discussion_r1967868744
##########
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##########
@@ -69,23 +70,24 @@ public class QuorumConfig {
public static final String QUORUM_ELECTION_TIMEOUT_MS_CONFIG =
QUORUM_PREFIX + "election.timeout.ms";
public static final String QUORUM_ELECTION_TIMEOUT_MS_DOC = "Maximum time
in milliseconds to wait " +
- "without being able to fetch from the leader before triggering a new
election";
+ "without being able to fetch from the leader before triggering a new
election, this value should large 0.";
Review Comment:
I don't think we need to add this to the document; the valid value section
already describes this limitation.
##########
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##########
@@ -69,23 +70,24 @@ public class QuorumConfig {
public static final String QUORUM_ELECTION_TIMEOUT_MS_CONFIG =
QUORUM_PREFIX + "election.timeout.ms";
public static final String QUORUM_ELECTION_TIMEOUT_MS_DOC = "Maximum time
in milliseconds to wait " +
- "without being able to fetch from the leader before triggering a new
election";
+ "without being able to fetch from the leader before triggering a new
election, this value should large 0.";
public static final int DEFAULT_QUORUM_ELECTION_TIMEOUT_MS = 1_000;
public static final String QUORUM_FETCH_TIMEOUT_MS_CONFIG = QUORUM_PREFIX
+ "fetch.timeout.ms";
public static final String QUORUM_FETCH_TIMEOUT_MS_DOC = "Maximum time
without a successful fetch from " +
"the current leader before becoming a candidate and triggering an
election for voters; Maximum time " +
- "a leader can go without receiving valid fetch or fetchSnapshot
request from a majority of the quorum before resigning.";
+ "a leader can go without receiving valid fetch or fetchSnapshot
request from a majority of the quorum before resigning, " +
+ "this value should large 0.";
public static final int DEFAULT_QUORUM_FETCH_TIMEOUT_MS = 2_000;
public static final String QUORUM_ELECTION_BACKOFF_MAX_MS_CONFIG =
QUORUM_PREFIX + "election.backoff.max.ms";
public static final String QUORUM_ELECTION_BACKOFF_MAX_MS_DOC = "Maximum
time in milliseconds before starting new elections. " +
- "This is used in the binary exponential backoff mechanism that helps
prevent gridlocked elections";
+ "This is used in the binary exponential backoff mechanism that helps
prevent gridlocked elections, this value should large 0.";
Review Comment:
ditto, I don't think we need to add this to the document; the valid value
section already describes this limitation.
##########
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##########
@@ -69,23 +70,24 @@ public class QuorumConfig {
public static final String QUORUM_ELECTION_TIMEOUT_MS_CONFIG =
QUORUM_PREFIX + "election.timeout.ms";
public static final String QUORUM_ELECTION_TIMEOUT_MS_DOC = "Maximum time
in milliseconds to wait " +
- "without being able to fetch from the leader before triggering a new
election";
+ "without being able to fetch from the leader before triggering a new
election, this value should large 0.";
public static final int DEFAULT_QUORUM_ELECTION_TIMEOUT_MS = 1_000;
public static final String QUORUM_FETCH_TIMEOUT_MS_CONFIG = QUORUM_PREFIX
+ "fetch.timeout.ms";
public static final String QUORUM_FETCH_TIMEOUT_MS_DOC = "Maximum time
without a successful fetch from " +
"the current leader before becoming a candidate and triggering an
election for voters; Maximum time " +
- "a leader can go without receiving valid fetch or fetchSnapshot
request from a majority of the quorum before resigning.";
+ "a leader can go without receiving valid fetch or fetchSnapshot
request from a majority of the quorum before resigning, " +
+ "this value should large 0.";
Review Comment:
ditto: I don't think we need to add this to the document; the valid value
section already describes this limitation.
##########
raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java:
##########
@@ -69,23 +70,24 @@ public class QuorumConfig {
public static final String QUORUM_ELECTION_TIMEOUT_MS_CONFIG =
QUORUM_PREFIX + "election.timeout.ms";
public static final String QUORUM_ELECTION_TIMEOUT_MS_DOC = "Maximum time
in milliseconds to wait " +
- "without being able to fetch from the leader before triggering a new
election";
+ "without being able to fetch from the leader before triggering a new
election, this value should large 0.";
public static final int DEFAULT_QUORUM_ELECTION_TIMEOUT_MS = 1_000;
public static final String QUORUM_FETCH_TIMEOUT_MS_CONFIG = QUORUM_PREFIX
+ "fetch.timeout.ms";
public static final String QUORUM_FETCH_TIMEOUT_MS_DOC = "Maximum time
without a successful fetch from " +
"the current leader before becoming a candidate and triggering an
election for voters; Maximum time " +
- "a leader can go without receiving valid fetch or fetchSnapshot
request from a majority of the quorum before resigning.";
+ "a leader can go without receiving valid fetch or fetchSnapshot
request from a majority of the quorum before resigning, " +
+ "this value should large 0.";
public static final int DEFAULT_QUORUM_FETCH_TIMEOUT_MS = 2_000;
public static final String QUORUM_ELECTION_BACKOFF_MAX_MS_CONFIG =
QUORUM_PREFIX + "election.backoff.max.ms";
public static final String QUORUM_ELECTION_BACKOFF_MAX_MS_DOC = "Maximum
time in milliseconds before starting new elections. " +
- "This is used in the binary exponential backoff mechanism that helps
prevent gridlocked elections";
+ "This is used in the binary exponential backoff mechanism that helps
prevent gridlocked elections, this value should large 0.";
public static final int DEFAULT_QUORUM_ELECTION_BACKOFF_MAX_MS = 1_000;
public static final String QUORUM_LINGER_MS_CONFIG = QUORUM_PREFIX +
"append.linger.ms";
public static final String QUORUM_LINGER_MS_DOC = "The duration in
milliseconds that the leader will " +
- "wait for writes to accumulate before flushing them to disk.";
+ "wait for writes to accumulate before flushing them to disk, this
value should large 0.";
Review Comment:
ditto, I don't think we need to add this to the document; the valid value
section already describes this limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
