adixitconfluent commented on code in PR #18864:
URL: https://github.com/apache/kafka/pull/18864#discussion_r1968938559


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignorTest.java:
##########
@@ -239,18 +272,20 @@ public void 
testAssignWithThreeMembersThreeTopicsHeterogeneous() {
             Assignment.EMPTY
         ));
 
-        String memberC = "C";
-        members.put(memberC, new MemberSubscriptionAndAssignmentImpl(
+        Set<Uuid> memberCTopicsSubscription = new LinkedHashSet<>();
+        memberCTopicsSubscription.add(TOPIC_2_UUID);
+        memberCTopicsSubscription.add(TOPIC_3_UUID);
+        members.put(MEMBER_C, new MemberSubscriptionAndAssignmentImpl(
             Optional.empty(),
             Optional.empty(),
-            Set.of(TOPIC_2_UUID, TOPIC_3_UUID),
+            memberCTopicsSubscription,

Review Comment:
   I deliberately initialized it as a `LinkedHashSet` because I wanted ordering 
of topics, so that I can write an assert for the expected assignment. Hence, I 
had to make this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to