mingdaoy commented on code in PR #19022:
URL: https://github.com/apache/kafka/pull/19022#discussion_r1969528734
##########
docs/design.html:
##########
@@ -264,7 +264,8 @@ <h3 class="anchor-heading"><a id="semantics"
class="anchor-link"></a><a href="#s
can fail, cases where there are multiple consumer processes, or cases
where data written to disk can be lost).
<p>
Kafka's semantics are straightforward. When publishing a message we have a
notion of the message being "committed" to the log. Once a published message is
committed, it will not be lost as long as one broker that
- replicates the partition to which this message was written remains
"alive". The definition of committed message and alive partition as well as a
description of which types of failures we attempt to handle will be
+ replicates the partition to which this message was written remains
"alive". More precisely, a message is considered committed only when all
replicas in the in-sync replicas (ISR) for that partition have applied it to
their log.
Review Comment:
Sounds great! Adjusted as @AndrewJSchofield suggested.
Thoughts? @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
