lianetm commented on code in PR #19024:
URL: https://github.com/apache/kafka/pull/19024#discussion_r1969823489
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerHeartbeatRequestManagerTest.java:
##########
@@ -1029,7 +1029,8 @@ private static Collection<Arguments> errorProvider() {
Arguments.of(Errors.UNSUPPORTED_VERSION, true),
Arguments.of(Errors.UNRELEASED_INSTANCE_ID, true),
Arguments.of(Errors.FENCED_INSTANCE_ID, true),
- Arguments.of(Errors.GROUP_MAX_SIZE_REACHED, true));
+ Arguments.of(Errors.GROUP_MAX_SIZE_REACHED, true),
+ Arguments.of(Errors.TOPIC_AUTHORIZATION_FAILED, true));
Review Comment:
nit: even thought it's a non-retriable exception, this is not considered
fatal in the client, so we should pass false here. (It doesn't affect the test
now because the isFatal param is not used in this specific case, but just to
make it right in case we change the test in the future)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
