lucasbru commented on code in PR #18963:
URL: https://github.com/apache/kafka/pull/18963#discussion_r1970571792
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -885,7 +885,8 @@ public Set<StreamTask> drainRestoredActiveTasks(final
Duration timeout) {
restoredActiveTasksLock.lock();
try {
while (restoredActiveTasks.isEmpty() && now <= deadline) {
- final boolean elapsed =
restoredActiveTasksCondition.await(deadline - now, TimeUnit.MILLISECONDS);
+ @SuppressWarnings("UnusedLocalVariable")
+ final boolean ignored =
restoredActiveTasksCondition.await(deadline - now, TimeUnit.MILLISECONDS);
Review Comment:
It really does not matter in that case whether we got interrupted or the
timeout expired. We could consider just removing the local here. It will be
flagged by intellij though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
