Re: [PR] KAFKA-18868: add the "default value" explanation to the docs of num.replica.alter.log.dirs.threads [kafka]

[via GitHub]

m1a2st commented on code in PR #19038:
URL: https://github.com/apache/kafka/pull/19038#discussion_r1971566712


##########
server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java:
##########
@@ -52,7 +52,8 @@ public class ServerConfigs {
     public static final String BACKGROUND_THREADS_DOC = "The number of threads 
to use for various background processing tasks";
 
     public static final String NUM_REPLICA_ALTER_LOG_DIRS_THREADS_CONFIG = 
"num.replica.alter.log.dirs.threads";
-    public static final String NUM_REPLICA_ALTER_LOG_DIRS_THREADS_DOC = "The 
number of threads that can move replicas between log directories, which may 
include disk I/O";
+    public static final String NUM_REPLICA_ALTER_LOG_DIRS_THREADS_DOC = "The 
number of threads that can move replicas between log directories, which may 
include disk I/O." +

Review Comment:
   Please add a space at the end of the sentence. 
   
   ![CleanShot 2025-02-26 at 21 19 
10](https://github.com/user-attachments/assets/493782b1-358f-4677-a79d-25492ddaf9e5)
   



##########
server/src/main/java/org/apache/kafka/server/config/ServerConfigs.java:
##########
@@ -52,7 +52,8 @@ public class ServerConfigs {
     public static final String BACKGROUND_THREADS_DOC = "The number of threads 
to use for various background processing tasks";
 
     public static final String NUM_REPLICA_ALTER_LOG_DIRS_THREADS_CONFIG = 
"num.replica.alter.log.dirs.threads";
-    public static final String NUM_REPLICA_ALTER_LOG_DIRS_THREADS_DOC = "The 
number of threads that can move replicas between log directories, which may 
include disk I/O";
+    public static final String NUM_REPLICA_ALTER_LOG_DIRS_THREADS_DOC = "The 
number of threads that can move replicas between log directories, which may 
include disk I/O." +
+            "The default value is equal to the number of directories specified 
in the " + ServerLogConfigs.LOG_DIRS_CONFIG + " configuration property.";

Review Comment:
   We should add code bolck for `ServerLogConfigs.LOG_DIRS_CONFIG`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org