[
https://issues.apache.org/jira/browse/KAFKA-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734467#comment-16734467
]
ASF GitHub Bot commented on KAFKA-6928:
---------------------------------------
guozhangwang commented on pull request #6085: KAFKA-6928: Refactor
StreamsPartitionAssignor retry logic
URL: https://github.com/apache/kafka/pull/6085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> StreamsPartitionAssignor is double retrying within InternalTopicManager
> -----------------------------------------------------------------------
>
> Key: KAFKA-6928
> URL: https://issues.apache.org/jira/browse/KAFKA-6928
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Guozhang Wang
> Assignee: Guozhang Wang
> Priority: Major
>
> Today inside StreamsPartitionAssingor, we are using the admin client to 1)
> check num.partitions for internal topics, 2) try to create internal topics
> that are not exist yet. We are using the StreamsConfig.RETRIES_CONFIG inside
> the InternalTopicManager to capture thrown exceptions from the resulted
> KafkaFuture; however inside the AdminClient, we are again using the same
> config with its own retrying logic.
> We should get rid of the outer retrying logic later; as of now (2018.05)
> there are still some issues with the admin client such that its own retrying
> logic is not safe. I'll leave it to [~hachikuji] to decide when admin
> client's own retrying is safe to rely on.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
