chia7712 commented on code in PR #19027:
URL: https://github.com/apache/kafka/pull/19027#discussion_r1972693467
##########
core/src/main/scala/kafka/server/ControllerApis.scala:
##########
@@ -642,9 +642,11 @@ class ControllerApis(
def createResponseCallback(requestThrottleMs: Int,
e: Throwable): UnregisterBrokerResponse = {
if (e != null) {
+ val errors = Errors.forException(e)
Review Comment:
Could you please leverage
`decommissionRequest.getErrorResponse(requestThrottleMs, e)`?
```java
if (e != null) {
decommissionRequest.getErrorResponse(requestThrottleMs, e)
} else {
new UnregisterBrokerResponse(new UnregisterBrokerResponseData().
setThrottleTimeMs(requestThrottleMs))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
