m1a2st commented on code in PR #19034:
URL: https://github.com/apache/kafka/pull/19034#discussion_r1973418908
##########
tests/kafkatest/services/kafka/quorum.py:
##########
@@ -14,14 +14,10 @@
# limitations under the License.
# the types of metadata quorums we support
-zk = 'ZK' # ZooKeeper, used before/during the KIP-500 bridge release(s)
-combined_kraft = 'COMBINED_KRAFT' # combined Controllers in KRaft mode, used
during/after the KIP-500 bridge release(s)
-isolated_kraft = 'ISOLATED_KRAFT' # isolated Controllers in KRaft mode, used
during/after the KIP-500 bridge release(s)
-
-# How we will parameterize tests that exercise all quorum styles
-# [“ZK”, “ISOLATED_KRAFT”, "COMBINED_KRAFT"] during the KIP-500 bridge
release(s)
-# [“ISOLATED_KRAFT”, "COMBINED_KRAFT”] after the KIP-500 bridge release(s)
-all = [zk, isolated_kraft, combined_kraft]
Review Comment:
`all = [zk, isolated_kraft, combined_kraft]` should not be removed, as it
represents this variable in quorum.py at line 32."
see the error log
```
TypeError("argument of type 'builtin_function_or_method' is not
iterable")
Traceback (most recent call last):
File
"/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line
351, in _do_run
data = self.run_test()
File
"/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line
411, in run_test
return self.test_context.function(self.test)
File "/usr/local/lib/python3.7/dist-packages/ducktape/mark/_mark.py", line
438, in wrapper
return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
File
"/opt/kafka-dev/tests/kafkatest/sanity_checks/test_performance_services.py",
line 43, in test_version
None, topics={self.topic: {'partitions': 1, 'replication-factor': 1}},
version=DEV_BRANCH)
File "/opt/kafka-dev/tests/kafkatest/services/kafka/kafka.py", line 282,
in __init__
self.quorum_info = quorum.ServiceQuorumInfo.from_test_context(self,
context)
File "/opt/kafka-dev/tests/kafkatest/services/kafka/quorum.py", line 109,
in from_test_context
quorum_type = for_test(context)
File "/opt/kafka-dev/tests/kafkatest/services/kafka/quorum.py", line 32,
in for_test
if retval not in all:
TypeError: argument of type 'builtin_function_or_method' is not iterable
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
