AndrewJSchofield commented on code in PR #19045:
URL: https://github.com/apache/kafka/pull/19045#discussion_r1975345141
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -313,6 +320,21 @@ public static RecordState forId(byte id) {
*/
private SharePartitionState partitionState;
+ /**
+ * The fetch lock acquired time is used to track the time when the lock
for share partition is acquired.
+ */
+ private long fetchLockAcquiredTimeMs;
Review Comment:
I think this should be `fetchLockAcquiredTime` and the next one should be
`fetchLockReleasedTime`. These two are snapshots of the current time. The
others are `...DurationMs` which is the difference in milliseconds between two
times. I think that if you make the two changes I said above, it's all
consistent. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
