dejan2609 commented on code in PR #18018:
URL: https://github.com/apache/kafka/pull/18018#discussion_r1977193479
##########
build.gradle:
##########
@@ -1916,6 +1913,10 @@ project(':clients') {
generator project(':generator')
}
+ tasks.withType(GenerateModuleMetadata) {
+ enabled = false
Review Comment:
@apoorvmittal10
It started with this comment made by @poom-kitti here:
https://github.com/apache/kafka/pull/18018#issuecomment-2637629283
Let me digest what is going on here just by using `kafka-clients` as an
external projects dependency.
Scenario:
- create a new project **_someNewProject_** and use `kafka-clients` as
dependency
- from `kafka` project: create three `kafka-clients` versions (using three
git commits, see below) and publish them into local maven repository
- execute `./gradlew dependencies` against **_someNewProject_** (while
rotating `kafka-clients` versions created in a previous step)
Results for **_someNewProject_** `./gradlew dependencies` command (and three
different `kafka-clients` versions):
1. Kafka trunk (with Gradle module metadata enabled by a default):
```
runtimeClasspath - Runtime classpath of source set 'main'.
\--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT-test-no-gradle-module
+--- com.github.luben:zstd-jni:1.5.6-6
+--- org.lz4:lz4-java:1.8.0
+--- org.xerial.snappy:snappy-java:1.1.10.5
\--- org.slf4j:slf4j-api:1.7.36
```
2. this PR HEAD~1 commit (with a new shadow plugin **AND** with Gradle
module metadata enabled by default):
```
runtimeClasspath - Runtime classpath of source set 'main'.
\--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT-test
```
3. this PR HEAD comit (with new shadow plugin AND with Gradle module
metadata explicitly disabled):
```
runtimeClasspath - Runtime classpath of source set 'main'.
\--- org.apache.kafka:kafka-clients:4.1.0-SNAPSHOT-test-no-gradle-module
+--- com.github.luben:zstd-jni:1.5.6-6
+--- org.lz4:lz4-java:1.8.0
+--- org.xerial.snappy:snappy-java:1.1.10.5
\--- org.slf4j:slf4j-api:1.7.36
```
(see my comment
https://github.com/apache/kafka/pull/18018#issuecomment-2645879873 for more
details about testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
