m1a2st commented on code in PR #19065:
URL: https://github.com/apache/kafka/pull/19065#discussion_r1977515801
##########
docs/ops.html:
##########
@@ -4187,7 +4187,7 @@ <h4 class="anchor-heading"><a
id="consumer_rebalance_protocol_server" class="anc
<p>The assignment strategy is also controlled by the server. The
<code>group.consumer.assignors</code> configuration can be used to specify the
list of available
assignors for <code>Consumer</code> groups. By default, the
<code>uniform</code> assignor and the <code>range</code> assignor are
configured. The first assignor
in the list is used by default unless the Consumer selects a different
one. It is also possible to implement custom assignment strategies on the
server side
- by implementing the
<code>org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionAssignor</code>
interface and specifying the full class name in the configuration.</p>
+ by implementing the <code style="font-size:
12px;">org.apache.kafka.coordinator.group.api.assignor.ConsumerGroupPartitionAssignor</code>
interface and specifying the full class name in the configuration.</p>
Review Comment:
> Unless consistent font size is the top priority, keeping the entire
package and class name on the same line makes it easier to copy, search and
read.
I don't think it's normal for the font size to vary when reading a document.
It seriously affects the reading experience.
> Adding a <br> line break within the class name could make it unsearchable
and cause hidden formatting issues in copy-pasting
Can you avoid using line breaks to split the code inside the code block and
only add them before and after the code block instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
