m1a2st commented on code in PR #19054:
URL: https://github.com/apache/kafka/pull/19054#discussion_r1979382072
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionStateManagerTest.scala:
##########
@@ -889,10 +889,13 @@ class TransactionStateManagerTest {
appendedRecords.values.foreach { batches =>
batches.foreach { records =>
records.records.forEach { record =>
- val transactionalId =
TransactionLog.readTxnRecordKey(record.key).transactionalId
- assertNull(record.value)
- expiredTransactionalIds += transactionalId
- assertEquals(Right(None),
transactionManager.getTransactionState(transactionalId))
+ TransactionLog.readTxnRecordKey(record.key) match {
+ case Right(transactionalId) =>
+ assertNull(record.value)
+ expiredTransactionalIds += transactionalId
+ assertEquals(Right(None),
transactionManager.getTransactionState(transactionalId))
+ case Left(value) => fail("Failed to read transactional id from
tombstone: " + value)
Review Comment:
nit: `fail(s"Failed to read transactional id from tombstone: $value")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
