AndrewJSchofield commented on PR #19057:
URL: https://github.com/apache/kafka/pull/19057#issuecomment-2697565099
> Could we use "composite" instead of "inheritance"?
>
> 1. move `DeleteGroupsResult` into internal package
> 2. add `delegate: DeleteGroupsResult` to `DeleteConsumerGroupsResult` and
`DeleteShareGroupsResult`
>
> ```java
> private final DeleteGroupsResult delegate;
> public DeleteConsumerGroupsResult(final Map<String, KafkaFuture<Void>>
futures) {
> this.delegate = new DeleteGroupsResult(futures);
> }
> ```
>
> With this approach, we can remove `DeleteGroupsResult` from public APIs
and maximize its internal reuse.
Good idea, @chia7712. We can move this forwards like this, and the potential
rationalisation step can be separate. @smjn, seems good to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
