chia7712 commented on code in PR #19097:
URL: https://github.com/apache/kafka/pull/19097#discussion_r1981591563
##########
docs/upgrade.html:
##########
@@ -46,6 +46,9 @@ <h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to
4.0.0 from any vers
Every <a
href="https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java">MetadataVersion</a>
has a boolean parameter that indicates if there are metadata changes
(i.e. <code>IBP_4_0_IV1(23, "4.0", "IV1", true)</code> means this version has
metadata changes).
Given your current and target versions, a downgrade is only possible
if there are no metadata changes in the versions between.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were
removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain
versions is not feasible.
Review Comment:
> perhaps make the current title more generic and creating a section
specifically for brokers under it.
"1.5 Upgrading From Previous Versions" is generic enough I think. we can
just move it out of "Upgrading to 4.0.0 ..." and create a individual title "
Kafka Client upgrade path for 4.x". for example:
## 1.5 Upgrading From Previous Versions
### Kafka Client upgrade path for 4.x
For the Kafka client upgrade path, note that many deprecated APIs were
removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain
versions is not feasible. For more information, please refer to
[KIP-1124](https://cwiki.apache.org/confluence/x/y4kgF).
### Upgrading to 4.1.0 from any version 3.3.x through 4.0.x
...
@ijuma WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]