mumrah commented on code in PR #18299:
URL: https://github.com/apache/kafka/pull/18299#discussion_r1981634646
##########
committer-tools/verify_license.py:
##########
@@ -74,12 +75,20 @@ def get_license_deps(license_text):
return set(LICENSE_DEP_PATTERN.findall(license_text))
def main():
+ # Argument parser
+ parser = argparse.ArgumentParser(description="Whether to skip executing
ReleaseTarGz.")
+ parser.add_argument('--skipReleaseTarGz', type=str, default=False,
help='Whether to skip ReleaseTarGz (true/false)')
Review Comment:
I would suggest a flag name like "rebuild" or similar.
Also, this is not the correct way to configure a boolean argument. You
should do something like:
```python
parser.add_argument("--my-flag", action="store_true", help="Help text")
```
https://docs.python.org/3/library/argparse.html#action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
