Re: [PR] KAFKA-17014: ScramFormatter should not use String for password [kafka]

Wed, 05 Mar 2025 13:34:32 -0800 


mingdaoy commented on code in PR #19082:
URL: https://github.com/apache/kafka/pull/19082#discussion_r1982214194


##########
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##########
@@ -173,7 +173,8 @@ byte[] saltedPassword(byte[] salt, int iterations) throws 
Exception {
                 return configuredSaltedPassword.get();
             }
             return new ScramFormatter(mechanism).saltedPassword(
-                    configuredPasswordString.get(),
+                    configuredPassword

Review Comment:
   @szetszwo Thanks for the review!
   
   ScramParserTest:
   
![image](https://github.com/user-attachments/assets/4aa9de14-f8e1-4b8d-9bcc-1f08cfcc2b18)



##########
metadata/src/main/java/org/apache/kafka/metadata/storage/ScramParser.java:
##########
@@ -173,7 +173,9 @@ byte[] saltedPassword(byte[] salt, int iterations) throws 
Exception {
                 return configuredSaltedPassword.get();
             }
             return new ScramFormatter(mechanism).saltedPassword(
-                    configuredPasswordString.get(),
+                    configuredPasswordString

Review Comment:
   ScramParserTest:
   
![image](https://github.com/user-attachments/assets/4aa9de14-f8e1-4b8d-9bcc-1f08cfcc2b18)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to