apoorvmittal10 commented on code in PR #19148:
URL: https://github.com/apache/kafka/pull/19148#discussion_r1985060904
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel,
val erroneous = mutable.Map.empty[TopicIdPartition,
ShareFetchResponseData.PartitionData]
erroneousAndValidPartitionData.erroneous.forEach { (topicIdPartition,
partitionData) => erroneous.put(topicIdPartition, partitionData) }
- val interestedWithMaxBytes = new util.LinkedHashMap[TopicIdPartition,
Integer]
+ val interestedTopicPartitions = new util.LinkedHashSet[TopicIdPartition]
Review Comment:
I think so that should be good enough. I was just thinking about how easy it
would be to rotate ArrayList vs LinkedList as that's the first thing we do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
