ahuang98 commented on code in PR #18600:
URL: https://github.com/apache/kafka/pull/18600#discussion_r1985666059
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -4704,4 +4715,21 @@ static ReplicaKey replicaKey(int id, boolean
withDirectoryId) {
static int randomReplicaId() {
return ThreadLocalRandom.current().nextInt(1025);
}
+
+ private static Stream<Arguments> generateTestDescribeQuorumMatrix() {
+ return Stream.of(
+ Arguments.of(KIP_853_PROTOCOL, true),
+ Arguments.of(KIP_853_PROTOCOL, false),
+ Arguments.of(KIP_595_PROTOCOL, false)
+ );
+ }
+
+ private static Stream<Arguments> generateTestObserverReplication() {
+ return Stream.of(
+ Arguments.of(KIP_853_PROTOCOL, true),
+ Arguments.of(KIP_853_PROTOCOL, false),
+ Arguments.of(KIP_853_PROTOCOL, true),
Review Comment:
this should be KIP_595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
