wernerdv commented on code in PR #18074:
URL: https://github.com/apache/kafka/pull/18074#discussion_r1986122644
##########
connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java:
##########
@@ -466,16 +466,16 @@ protected boolean readPartition(TopicPartition
topicPartition) {
return true;
}
- private void poll(long timeoutMs) {
+ private void poll() {
try {
- ConsumerRecords<K, V> records =
consumer.poll(Duration.ofMillis(timeoutMs));
+ ConsumerRecords<K, V> records =
consumer.poll(Duration.ofMillis(Integer.MAX_VALUE));
Review Comment:
@ashrivastava88 If you look at the trunk before this commit was merged, you
can see that the method KafkaBasedLog#poll was used in only 2 places with the
argument timeoutMs=Integer.MAX_VALUE.
So, in this PR, I did not change the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
