m1a2st commented on code in PR #19141:
URL: https://github.com/apache/kafka/pull/19141#discussion_r1986509562
##########
docs/upgrade.html:
##########
@@ -385,21 +385,21 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
See <a
href="https://cwiki.apache.org/confluence/x/jA3OEg";>KIP-1074</a> for more
details.
</li>
<li>
- KIP-714 is now enabled for Kafka Streams via <a
href="https://cwiki.apache.org/confluence/x/XA-OEg";>KIP-1076</a>.
+ <a
href="https://cwiki.apache.org/confluence/x/2xRRCg";>KIP-714</a> is now enabled
for Kafka Streams via <a
href="https://cwiki.apache.org/confluence/x/XA-OEg";>KIP-1076</a>.
This allows to not only collect the metric of the
internally used clients of a Kafka Streams application via a broker-side plugin,
but also to collect the <a
href="/{{version}}/documentation/#kafka_streams_monitoring">metrics</a> of the
Kafka Streams runtime itself.
</li>
<li>
- The default value of 'num.recovery.threads.per.data.dir'
has been changed from 1 to 2. The impact of this is faster
+ The default value of
<code>num.recovery.threads.per.data.dir</code> has been changed from 1 to 2.
The impact of this is faster
recovery post unclean shutdown at the expense of extra IO
cycles.
- See <a
href="https://cwiki.apache.org/confluence/x/FAqpEQ";>KIP-1030</a>
+ See <a
href="https://cwiki.apache.org/confluence/x/FAqpEQ";>KIP-1030</a>
</li>
<li>
- The default value of 'message.timestamp.after.max.ms' has
been changed from Long.Max to 1 hour. The impact of this messages with a
+ The default value of
<code>message.timestamp.after.max.ms</code> has been changed from Long.Max to 1
hour. The impact of this messages with a
timestamp of more than 1 hour in the future will be
rejected when message.timestamp.type=CreateTime is set.
- See <a
href="https://cwiki.apache.org/confluence/x/FAqpEQ";>KIP-1030</a>
+ See <a
href="https://cwiki.apache.org/confluence/x/FAqpEQ";>KIP-1030</a>
</li>
- <li>Introduced in KIP-890, the
<code>TransactionAbortableException</code> enhances error handling within
transactional operations by clearly indicating scenarios where transactions
should be aborted due to errors. It is important for applications to properly
manage both <code>TimeoutException</code> and
<code>TransactionAbortableException</code> when working with transaction
producers.</li>
+ <li>Introduced in <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-890%3A+Transactions+Server-Side+Defense";>KIP-890</a>,
the <code>TransactionAbortableException</code> enhances error handling within
transactional operations by clearly indicating scenarios where transactions
should be aborted due to errors. It is important for applications to properly
manage both <code>TimeoutException</code> and
<code>TransactionAbortableException</code> when working with transaction
producers.</li>
Review Comment:
Could you also update the KIP link to
`https://cwiki.apache.org/confluence/x/B40ODg`? If the KIP title changes in the
future, the current URL may become invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
