dajac commented on code in PR #19119:
URL: https://github.com/apache/kafka/pull/19119#discussion_r1991078954
##########
docs/upgrade.html:
##########
@@ -52,9 +73,6 @@ <h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to
4.0.0 from any vers
Every <a
href="https://github.com/apache/kafka/blob/trunk/server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java";>MetadataVersion</a>
has a boolean parameter that indicates if there are metadata changes
(i.e. <code>IBP_4_0_IV1(23, "4.0", "IV1", true)</code> means this version has
metadata changes).
Given your current and target versions, a downgrade is only possible
if there are no metadata changes in the versions between.</li>
- <li>For the Kafka client upgrade path, note that many deprecated APIs were
removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain
versions is not feasible.
- For more information, please refer to <a
href="https://cwiki.apache.org/confluence/x/y4kgF";>KIP-1124</a>.
- </li>
</ol>
<h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable
changes in 4.0.0</a></h5>
Review Comment:
nit: Should we use `upgrade_servers_400_notable`?
##########
docs/upgrade.html:
##########
@@ -29,7 +31,26 @@ <h5><a id="upgrade_410_notable"
href="#upgrade_410_notable">Notable changes in 4
</ul>
</li>
</ul>
-<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0 from any
version 3.3.x through 3.9.x</a></h4>
+
+<h4><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading to 4.0.0</a></h4>
+
+<h5><a id="upgrade_clients_4_0_0" href="#upgrade_clients_4_0_0">Upgrading
Clients to 4.0.0</a></h5>
+
+<p><b>For a rolling upgrade:</b></p>
+
+<ol>
+ <li>Upgrade the clients one at a time: shut down the client, update the
code, and restart it.</li>
+ <li>For the Kafka client upgrade path, note that many deprecated APIs were
removed in Kafka 4.0. Additionally, upgrading directly to 4.x from certain
versions is not feasible.
+ For more information, please refer to <a
href="https://cwiki.apache.org/confluence/x/y4kgF";>KIP-1124</a>.</li>
Review Comment:
I wonder whether we should call out that 2.1 is the minimum required version
here KIP-896.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
