mimaison commented on code in PR #19175:
URL: https://github.com/apache/kafka/pull/19175#discussion_r1991877823
##########
core/src/main/scala/kafka/metrics/KafkaMetricsReporter.scala:
##########
@@ -62,7 +63,7 @@ object KafkaMetricsReporter {
val metricsConfig = new KafkaMetricsConfig(verifiableProps)
if (metricsConfig.reporters.nonEmpty) {
metricsConfig.reporters.foreach(reporterType => {
- val reporter =
CoreUtils.createObject[KafkaMetricsReporter](reporterType)
Review Comment:
I kept the logic in `DumpLogSegments` because once
https://github.com/apache/kafka/pull/19030 gets merged we will be able to
rewrite `DumpLogSegments`. So I did not want to change the Scala code that will
be deleted hopefully very soon (I have a PR almost ready).
I guess while I'm touching `CoreUtils`, I may as well delete this method.
I'll push an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
