mimaison commented on code in PR #18930:
URL: https://github.com/apache/kafka/pull/18930#discussion_r2011825612
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java:
##########
@@ -320,6 +321,10 @@ String entityLabel() {
in(Utils.enumOptions(SecurityProtocol.class)),
ConfigDef.Importance.MEDIUM,
CommonClientConfigs.SECURITY_PROTOCOL_DOC)
+ .define(CONFIG_PROVIDERS_CONFIG,
+ ConfigDef.Type.LIST,
+ Collections.emptyList(),
+ ConfigDef.Importance.LOW, CONFIG_PROVIDERS_DOC)
Review Comment:
Nit: Put the DOC on a new line like the other configs. Same in other files
below.
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -65,6 +65,11 @@ public class AbstractConfig {
public static final String AUTOMATIC_CONFIG_PROVIDERS_PROPERTY =
"org.apache.kafka.automatic.config.providers";
public static final String CONFIG_PROVIDERS_CONFIG = "config.providers";
+ protected static final String CONFIG_PROVIDERS_DOC =
+ "Comma-separated names of <code>ConfigProvider</code> classes,
loaded and used "
+ + "in the order specified. Implementing the interface "
+ + "<code>ConfigProvider</code> allows you to replace variable
references in connector configurations, "
Review Comment:
The reference to `connectors` should be updated.
##########
clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java:
##########
@@ -289,6 +295,13 @@ protected Map<String, Object>
postProcessParsedConfig(final Map<String, Object>
CommonClientConfigs.warnDisablingExponentialBackoff(this);
return CommonClientConfigs.postProcessReconnectBackoffConfigs(this,
parsedValues);
}
+
+ @Override
+ public Map<String, Object> originals() {
Review Comment:
Can you clarify why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
