matt-welch commented on code in PR #17340:
URL: https://github.com/apache/kafka/pull/17340#discussion_r2010980706
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -94,7 +101,19 @@ void start(String[] args) throws IOException {
record = new ProducerRecord<>(config.topicName, payload);
long sendStartMs = System.currentTimeMillis();
- cb = new PerfCallback(sendStartMs, payload.length, stats);
Review Comment:
Thanks for the suggestion! I think the refactored conditional is much
easier to understand. Hopefully nobody minds the passing of null
steadyStateStats. I've refactored this in my latest commit.
##########
tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java:
##########
@@ -75,7 +76,13 @@ void start(String[] args) throws IOException {
// not thread-safe, do not share with other threads
SplittableRandom random = new SplittableRandom(0);
ProducerRecord<byte[], byte[]> record;
- stats = new Stats(config.numRecords, 5000);
+
+ System.out.println("DEBUG: config.warmupRecords=" +
config.warmupRecords + ", (config.warmupRecords > 0)=" + (config.warmupRecords
> 0));
Review Comment:
That's correct. Chia-Ping had asked for some clarification around
config.warmupRecords. Once he's satisfied with that output, the line will be
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
