[
https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938829#comment-17938829
]
Dmitry Werner edited comment on KAFKA-14485 at 3/27/25 7:31 AM:
----------------------------------------------------------------
[~chia7712] [~mimaison]
The current LogCleaner implements the `kafka.server.BrokerReconfigurable`
interface.
The new interface `org.apache.kafka.server.config.BrokerReconfigurable` belongs
to the `server` module, which depends on the `storage` module.
To avoid circular module dependencies, we could:
- Move org.apache.kafka.server.config.BrokerReconfigurable,
AbstractKafkaConfig, and all dependent classes (KRaftConfigs, ServerConfigs,
etc.) to the `server-common` module, but this would require extensive changes
across the project.
- Alternatively, extract all config classes into a separate module (e.g.,
`config`).
Do you have any better suggestions for solving this problem?
was (Author: JIRAUSER300605):
[~chia7712] [~mimaison]
The current LogCleaner implements the kafka.server.BrokerReconfigurable
interface.
The new interface org.apache.kafka.server.config.BrokerReconfigurable belongs
to the `server` module, which depends on the `storage` module.
To avoid circular module dependencies, we could:
- Move org.apache.kafka.server.config.BrokerReconfigurable,
AbstractKafkaConfig, and all dependent classes (KRaftConfigs, ServerConfigs,
etc.) to the `server-common` module, but this would require extensive changes
across the project.
- Alternatively, extract all config classes into a separate module (e.g.,
`config`).
Do you have any better suggestions for solving this problem?
> Move LogCleaner to storage module
> ---------------------------------
>
> Key: KAFKA-14485
> URL: https://issues.apache.org/jira/browse/KAFKA-14485
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Ismael Juma
> Assignee: Dmitry Werner
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
