[ 
https://issues.apache.org/jira/browse/KAFKA-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743496#comment-16743496
 ] 

ASF GitHub Bot commented on KAFKA-3522:
---------------------------------------

mjsax commented on pull request #6152: KAFKA-3522: Add 
KeyValueWithTimestampStore builder/runtime classes
URL: https://github.com/apache/kafka/pull/6152
 
 
   Part of KIP-258.
   
   This is mostly internal changes, however depends on public interfaces that 
are added via #6151). This PR contains some duplication to #6151 to make it 
compile:
    - KeyValueWithTimestampStore
    - ValueAndTimestamp / ValueAndTimestampImpl
    - ValueAndTimestampSerializer / ValueAndTimestampDeserializer
   
   The actual change of this PR is to add
    - KeyValueWithTimestampStoreBuilder
    - MeteredKeyValueWithTimestampStore
    - CachingKeyValueWithTimestampStore
    - ChangeLoggingKeyValueWithTimestampStore
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Consider adding version information into rocksDB storage format
> ---------------------------------------------------------------
>
>                 Key: KAFKA-3522
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3522
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>            Reporter: Guozhang Wang
>            Assignee: Matthias J. Sax
>            Priority: Major
>              Labels: architecture
>
> Kafka Streams does not introduce any modifications to the data format in the 
> underlying Kafka protocol, but it does use RocksDB for persistent state 
> storage, and currently its data format is fixed and hard-coded. We want to 
> consider the evolution path in the future we we change the data format, and 
> hence having some version info stored along with the storage file / directory 
> would be useful.
> And this information could be even out of the storage file; for example, we 
> can just use a small "version indicator" file in the rocksdb directory for 
> this purposes. Thoughts? [~enothereska] [~jkreps]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to