smjn commented on code in PR #19328:
URL: https://github.com/apache/kafka/pull/19328#discussion_r2024601473
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3533,19 +3539,74 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
- private def describeShareGroupOffsetsForGroup(requestContext: RequestContext,
+ private def describeShareGroupAllOffsetsForGroup(requestContext:
RequestContext,
groupDescribeOffsetsRequest:
DescribeShareGroupOffsetsRequestData.DescribeShareGroupOffsetsRequestGroup
):
CompletableFuture[DescribeShareGroupOffsetsResponseData.DescribeShareGroupOffsetsResponseGroup]
= {
- groupCoordinator.describeShareGroupOffsets(
+ groupCoordinator.describeShareGroupAllOffsets(
requestContext,
groupDescribeOffsetsRequest
).handle[DescribeShareGroupOffsetsResponseData.DescribeShareGroupOffsetsResponseGroup]
{ (groupDescribeOffsetsResponse, exception) =>
if (exception != null) {
new
DescribeShareGroupOffsetsResponseData.DescribeShareGroupOffsetsResponseGroup()
.setGroupId(groupDescribeOffsetsRequest.groupId)
.setErrorCode(Errors.forException(exception).code)
+ .setErrorMessage(Errors.forException(exception).message)
} else {
+ // Clients are not allowed to see offsets for topics that are not
authorized for Describe.
+ val (authorizedOffsets, _) = authHelper.partitionSeqByAuthorized(
+ requestContext,
+ DESCRIBE,
+ TOPIC,
+ groupDescribeOffsetsResponse.topics.asScala
+ )(_.topicName)
+ groupDescribeOffsetsResponse.setTopics(authorizedOffsets.asJava)
+ }
+ }
+ }
+
+ private def describeShareGroupOffsetsForGroup(requestContext: RequestContext,
+ groupDescribeOffsetsRequest:
DescribeShareGroupOffsetsRequestData.DescribeShareGroupOffsetsRequestGroup
+ ):
CompletableFuture[DescribeShareGroupOffsetsResponseData.DescribeShareGroupOffsetsResponseGroup]
= {
+ // Clients are not allowed to see offsets for topics that are not
authorized for Describe.
+ val (authorizedTopics, unauthorizedTopics) =
authHelper.partitionSeqByAuthorized(
+ requestContext,
+ DESCRIBE,
+ TOPIC,
+ groupDescribeOffsetsRequest.topics.asScala
+ )(_.topicName)
+
+ groupCoordinator.describeShareGroupOffsets(
+ requestContext,
+ new
DescribeShareGroupOffsetsRequestData.DescribeShareGroupOffsetsRequestGroup()
+ .setGroupId(groupDescribeOffsetsRequest.groupId)
+ .setTopics(authorizedTopics.asJava)
+
).handle[DescribeShareGroupOffsetsResponseData.DescribeShareGroupOffsetsResponseGroup]
{ (groupDescribeOffsetsResponse, exception) =>
+ if (exception != null) {
+ new
DescribeShareGroupOffsetsResponseData.DescribeShareGroupOffsetsResponseGroup()
+ .setGroupId(groupDescribeOffsetsRequest.groupId)
+ .setErrorCode(Errors.forException(exception).code)
Review Comment:
nit: could we create a val Error and use that here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
