frankvicky commented on code in PR #19269:
URL: https://github.com/apache/kafka/pull/19269#discussion_r2025052348
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java:
##########
@@ -70,6 +70,7 @@ public class StreamsProducer {
private Producer<byte[], byte[]> producer;
private boolean transactionInFlight = false;
private boolean transactionInitialized = false;
+ private boolean resetDisabled = false;
Review Comment:
Thanks for the comment 🙇🏼
This is interesting.
The flag described whether the producer could be reset, so I added the
flange to the producer itself.
Adding a boolean `isClosed` flag to `ActiveTaskCreator` is also suitable for
me, but given that this flag is only for producer reset, I would prefer to keep
the current design.
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
