lucasbru commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2028472624
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(String
groupId) {
* Get the assignor of the provided streams group.
*/
private Map<String, String> streamsGroupAssignmentConfigs(String groupId) {
Review Comment:
This is just prepared to have more assignment configs - e.g.
`max_warmup_replicas`. In the future, there will be more assignment configs
that we need to pass around. We could alternatively just have a little class
(`StreamsAssignmentConfigs` or something). Having a simple map would make it
easier adding a pluggable assignor interface later on, since there is less
worrying about compatibility with primitive types. But if you prefer, we can
add a container with names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
