ShivsundarR commented on code in PR #19192:
URL: https://github.com/apache/kafka/pull/19192#discussion_r2012626389
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java:
##########
@@ -1223,21 +1343,15 @@ public void
testAcknowledgementCommitCallbackMultiplePartitionCommitAsync() {
networkClientDelegate.poll(time.timer(0));
assertTrue(shareConsumeRequestManager.hasCompletedFetches());
- Acknowledgements acknowledgements = Acknowledgements.empty();
- acknowledgements.add(0L, AcknowledgeType.ACCEPT);
- acknowledgements.add(1L, AcknowledgeType.ACCEPT);
- acknowledgements.add(2L, AcknowledgeType.ACCEPT);
+ Acknowledgements acknowledgements = getAcknowledgements(1,
AcknowledgeType.ACCEPT, AcknowledgeType.ACCEPT, AcknowledgeType.REJECT);
- Acknowledgements acknowledgements2 = Acknowledgements.empty();
- acknowledgements2.add(0L, AcknowledgeType.ACCEPT);
- acknowledgements2.add(1L, AcknowledgeType.ACCEPT);
- acknowledgements2.add(2L, AcknowledgeType.ACCEPT);
+ Acknowledgements acknowledgements2 = getAcknowledgements(1,
AcknowledgeType.ACCEPT, AcknowledgeType.ACCEPT, AcknowledgeType.REJECT);
Review Comment:
This was intended too, again just to have a different acknowledge type in
the 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
