splett2 commented on code in PR #19296:
URL: https://github.com/apache/kafka/pull/19296#discussion_r2036067232
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -353,10 +353,10 @@ public ControllerResult<BrokerRegistrationReply>
registerBroker(
if (existing != null) {
prevIncarnationId = existing.incarnationId();
storedBrokerEpoch = existing.epoch();
- if (heartbeatManager.hasValidSession(brokerId, existing.epoch())) {
+ if (heartbeatManager.hasValidSession(brokerId, existing.epoch())
&& !existing.inControlledShutdown()) {
Review Comment:
does the broker ever transition from controlledShutdown to fenced as part of
the shutting down process? or is `inControlledShutdown` a terminal state for a
broker epoch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
