lucasbru commented on code in PR #19438:
URL: https://github.com/apache/kafka/pull/19438#discussion_r2039158740
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/streams/topics/ChangelogTopicsTest.java:
##########
@@ -149,14 +149,14 @@ public void shouldContainNonSourceBasedChangelogs() {
}
@Test
- public void shouldNotContainSourceBasedChangelogs() {
+ public void shouldContainSourceBasedChangelogs() {
Review Comment:
Yeah. Beforehand the contract of the class was to not include the partition
count for source-topic changelogs (resulting from that Kafka Streams
optimization). But this caused a problem, that later on we wanted to look up
the partition count for those topics, and not find it. So I changed the
contract to also incldeu source-topic changelogs in the result. Hope that
explains things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
