jsancio commented on code in PR #19448:
URL: https://github.com/apache/kafka/pull/19448#discussion_r2042374432
##########
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##########
@@ -1053,7 +1053,8 @@ class KRaftClusterTest {
val cluster = new KafkaClusterTestKit.Builder(
new TestKitNodes.Builder().
setNumBrokerNodes(1).
- setNumControllerNodes(1).build()).build()
+ setNumControllerNodes(1).
+ setFeature(KRaftVersion.FEATURE_NAME, 1.toShort).build()).build()
Review Comment:
Yeah. This doesn't emulate or mock kraft.version correctly. Remember that
kraft version are persisted and replicated using the KRaftVersion control
record and not the FeatureLevelRecord metadata record.
This is why I didn't re-implement this in the cherry-pick but I forgot to
run this suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
