LoganZhuZzz commented on code in PR #19388:
URL: https://github.com/apache/kafka/pull/19388#discussion_r2044558308
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java:
##########
@@ -263,21 +260,10 @@ private CompletedFetch handleInitializeSuccess(final
CompletedFetch completedFet
Iterator<? extends RecordBatch> batches =
FetchResponse.recordsOrFail(partition).batches().iterator();
if (!batches.hasNext() && FetchResponse.recordsSize(partition) > 0) {
- if (completedFetch.requestVersion < 3) {
Review Comment:
> `requestVersion` is useless now. could you please remove it as well?
Apologies, I overlooked the `CompletedFetch` part. It’s removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
