AndrewJSchofield commented on code in PR #19477:
URL: https://github.com/apache/kafka/pull/19477#discussion_r2047598546
##########
clients/src/main/java/org/apache/kafka/clients/admin/ListGroupsOptions.java:
##########
@@ -32,8 +33,19 @@
@InterfaceStability.Evolving
public class ListGroupsOptions extends AbstractOptions<ListGroupsOptions> {
- private Set<GroupState> groupStates = Collections.emptySet();
- private Set<GroupType> types = Collections.emptySet();
+ private Set<GroupState> groupStates = Set.of();
+ private Set<GroupType> types = Set.of();
+ private Set<String> protocolTypes = Set.of();
+
+ /**
+ * Only consumer groups will be returned by listGroups().
+ * This operation sets filters on group type and protocol type which
select consumer groups.
+ */
+ public ListGroupsOptions forConsumerGroups() {
Review Comment:
Yes, I agree. I was trying to see what the best way to express this would be
and I like the static method suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
