apoorvmittal10 commented on code in PR #19430:
URL: https://github.com/apache/kafka/pull/19430#discussion_r2048869119
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1011,6 +1011,8 @@ private Optional<Throwable>
releaseAcquiredRecordsForPerOffsetBatch(String membe
return Optional.empty();
}
if (offsetState.getValue().state == RecordState.ACQUIRED) {
+ // These records were fetched but they were not actually
delivered to the client.
+ offsetState.getValue().tryReleaseDeliveryCount();
Review Comment:
Sorry for the delay, I think either approach which you find sensible and
readable should work. I might have preferred the enum based as that would be
easy to read in future, tracking multiple booleans could be hard. But again,
see how does it come after changes and choose either which you find sensible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
