chia7712 commented on code in PR #19460:
URL: https://github.com/apache/kafka/pull/19460#discussion_r2062664349
##########
checkstyle/import-control-clients-integration-tests.xml:
##########
@@ -21,6 +21,7 @@
<import-control pkg="org.apache.kafka">
<allow pkg="java"/>
<allow pkg="org.junit"/>
+ <allow pkg="scala" />
Review Comment:
yes, see
https://github.com/apache/kafka/blob/trunk/clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ListOffsetsIntegrationTest.java#L246
we can file a minor PR to move the method `logDirs` to `AbstractKafkaConfig`
(java) to remove the usage of converter. the scala type `Seq[Int]` (`logDirs`)
has no unplaceable usage in code base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
