smjn commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2099514458
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8061,6 +8075,74 @@ public
List<DeleteShareGroupStateRequestData.DeleteStateData> sharePartitionsEli
return deleteShareGroupStateRequestTopicsData;
}
+ public Map.Entry<AlterShareGroupOffsetsResponseData,
InitializeShareGroupStateParameters> completeAlterShareGroupOffsets(
+ String groupId,
+ AlterShareGroupOffsetsRequestData alterShareGroupOffsetsRequest,
+ List<CoordinatorRecord> records
+ ) {
+ Group group = groups.get(groupId);
+
List<AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponseTopic>
alterShareGroupOffsetsResponseTopics = new ArrayList<>();
+
+ Map<Uuid, Set<Integer>> initializingTopics = new HashMap<>();
+ Map<Uuid, Map<Integer, Long>> offsetByTopicPartitions = new
HashMap<>();
+
+ alterShareGroupOffsetsRequest.topics().forEach(topic -> {
+ TopicImage topicImage =
metadataImage.topics().getTopic(topic.topicName());
+ if (topicImage != null) {
+ Uuid topicId = topicImage.id();
+ Set<Integer> existingPartitions = new
HashSet<>(topicImage.partitions().keySet());
+
List<AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponsePartition>
partitions = new ArrayList<>();
+ topic.partitions().forEach(partition -> {
+ if
(existingPartitions.contains(partition.partitionIndex())) {
+ partitions.add(
+ new
AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponsePartition()
+ .setPartitionIndex(partition.partitionIndex())
+ .setErrorCode(Errors.NONE.code()));
+ offsetByTopicPartitions.computeIfAbsent(topicId, k ->
new HashMap<>()).put(partition.partitionIndex(), partition.startOffset());
+ } else {
+ partitions.add(
+ new
AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponsePartition()
+ .setPartitionIndex(partition.partitionIndex())
+
.setErrorCode(Errors.UNKNOWN_TOPIC_OR_PARTITION.code())
+
.setErrorMessage(Errors.UNKNOWN_TOPIC_OR_PARTITION.message()));
+ }
+ });
+
+ initializingTopics.put(topicId, topic.partitions().stream()
+
.map(AlterShareGroupOffsetsRequestData.AlterShareGroupOffsetsRequestPartition::partitionIndex)
+ .filter(existingPartitions::contains)
+ .collect(Collectors.toSet()));
+
+ alterShareGroupOffsetsResponseTopics.add(
+ new
AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponseTopic()
+ .setTopicName(topic.topicName())
+ .setTopicId(topicId)
+ .setPartitions(partitions)
+ );
+
+ } else {
+
List<AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponsePartition>
partitions = new ArrayList<>();
+ topic.partitions().forEach(partition -> partitions.add(
+ new
AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponsePartition()
+ .setPartitionIndex(partition.partitionIndex())
+ .setErrorCode(Errors.UNKNOWN_TOPIC_OR_PARTITION.code())
+
.setErrorMessage(Errors.UNKNOWN_TOPIC_OR_PARTITION.message())));
+ alterShareGroupOffsetsResponseTopics.add(
+ new
AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponseTopic()
+ .setTopicName(topic.topicName())
Review Comment:
topic Id missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
