MahsaSeifikar commented on code in PR #19742:
URL: https://github.com/apache/kafka/pull/19742#discussion_r2102601862
##########
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##########
@@ -451,6 +452,43 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
}
}
+ /**
+ * Helper method to update quota types counts and quotaTypesEnabled flag.
+ * @param quotaTypeKey The QuotaTypes constant (e.g.,
QuotaTypes.UserClientIdQuotaEnabled)
+ * @param increment True to increment count, false to decrement
+ */
+ private def updateQuotaTypes(quotaTypeKey: Int, increment: Boolean): Unit = {
+ if (quotaTypeKey == QuotaTypes.NoQuotas) {
+ return
+ }
+ val previousQuotaTypesEnabled = quotaTypesEnabled
+
+ // Update activeQuotaTypes counts
+ activeQuotaTypes.compute(quotaTypeKey, (_, count) =>
+ if (increment) Option(count).getOrElse(0) + 1
+ else if (Option(count).exists(_ > 1)) count - 1
+ else 0
+ )
+
+ // Update quotaTypesEnabled based on activeQuotaTypes counts
+ quotaTypesEnabled = clientQuotaCallbackPlugin match {
+ case Some(_) => QuotaTypes.CustomQuotas
+ case None =>
+ var newQuotaTypes = QuotaTypes.NoQuotas
+ if (activeQuotaTypes.getOrDefault(QuotaTypes.UserClientIdQuotaEnabled,
0) > 0)
+ newQuotaTypes |= QuotaTypes.UserClientIdQuotaEnabled
Review Comment:
Since the base value of `newQuotaTypes` is NoQuotas, and `x | 0 = x`, I kept
`|=` operator to emphasize that we are using a bitwise OR to calculate
newQuotaTypes. Both `newQuotaTypes = QuotaTypes.UserClientIdQuotaEnabled` and
`newQuotaTypes |= QuotaTypes.UserClientIdQuotaEnabled` have the same result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
