brandboat commented on code in PR #19879: URL: https://github.com/apache/kafka/pull/19879#discussion_r2122691026
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -216,7 +208,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) def quotaConfig: QuotaConfig = _quotaConfig /** ********* General Configuration ***********/ - var brokerId: Int = getInt(ServerConfigs.BROKER_ID_CONFIG) Review Comment: Nope, this config is used in quite a few places, e.g. Partition.scala. But yeah, moving it to AbstractKafkaConfig is totally fine since KafkaConfig.scala extends AbstractKafkaConfig.java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
