ahuang98 commented on code in PR #19916:
URL: https://github.com/apache/kafka/pull/19916#discussion_r2141096329
##########
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##########
@@ -428,6 +428,231 @@ public void testClearElrRecords() {
assertEquals(0,
image.getTopic(barId).partitions().get(0).lastKnownElr.length);
}
+ @Test
+ public void testClearElrRecordOnNonExistingTopic() {
+ TopicsImage image = TopicsImage.EMPTY;
+
+ List<ApiMessageAndVersion> topicRecords = new ArrayList<>();
+ topicRecords.addAll(List.of(
+ new ApiMessageAndVersion(
+ new ClearElrRecord().setTopicName("foo"),
+ CLEAR_ELR_RECORD.highestSupportedVersion()
+ ))
+ );
+ TopicsDelta delta = new TopicsDelta(image, __ -> null);
+ assertThrows(RuntimeException.class, () ->
RecordTestUtils.replayAll(delta, topicRecords));
+ }
+
+ @Test
+ public void testClearElrRecords_All_ForDeletedTopics() {
+ Uuid fooId = Uuid.fromString("0hHJ3X5ZQ-CFfQ5xgpj90w");
+ Uuid fooId2 = Uuid.randomUuid();
+ Uuid barId = Uuid.fromString("f62ptyETTjet8SL5ZeREiw");
+ Uuid barId2 = Uuid.randomUuid();
+
+ List<TopicImage> topics = new ArrayList<>();
+ topics.add(
+ newTopicImage(
+ "foo",
+ fooId,
+ NULL_MIRROR_TOPIC_STATE,
Review Comment:
😬
noticed the build failed, think we need to alter some of these tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
