[ 
https://issues.apache.org/jira/browse/KAFKA-19404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17966279#comment-17966279
 ] 

Greg Harris commented on KAFKA-19404:
-------------------------------------

Hi [~mimaison] Thanks for the ticket. I agree that this documentation should be 
improved.

However I wanted to clarify that your example hierarchy is not a recommended 
layout if those plugins are independently versioned/packaged. This is because 
the plugins are (intentionally) visible, but they will merge their dependencies 
and potentially have version conflicts.

So this is an acceptable layout which demonstrates the nesting.
{noformat}
/var/plugins 
├── nested1 
│   └── nested1a 
│       ├── plugin1  
│       │   └── plugin1.jar
│       └── dependency1 
│           └── dependency1.jar
└── nested2 
    ├── nested2a
    │   ├── plugin2 
    │   │   └── plugin2.jar
    │   └── plugin3     
    │       └── plugin3.jar
    └── dependency2and3
         └── dependency2and3.jar {noformat}
Does this edit make sense?
{quote}a) directories -immediately- *recursively* containing jars with plugins 
and their dependencies
{quote}

> Connect's plugin.path documentation does not match behavior
> -----------------------------------------------------------
>
>                 Key: KAFKA-19404
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19404
>             Project: Kafka
>          Issue Type: Task
>          Components: connect
>            Reporter: Mickael Maison
>            Priority: Major
>
> The doc currently states:
> {quote}The list should consist of top level directories that include any 
> combination of:
> a) directories immediately containing jars with plugins and their dependencies
> b) uber-jars with plugins and their dependencies
> c) directories immediately containing the package directory structure of 
> classes of plugins and their dependencies
> {quote}
> In practice plugins are found even if they are in nested directories. For 
> example we can set {{plugin.path}} to {{/var/plugins}} and it will find all 
> these plugins:
> {noformat}
> /var/plugins
> └── nested1
>     └── nested2
>         ├── plugin1
>         │   └── plugin1.jar
>         ├── plugin2
>         │   └── plugin2.jar
>         ├── plugin3
>             └── plugin3.jar
> {noformat}
> I think we should adjust the documentation to match the current behavior



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to